Fix IPv6 handling in WOPI allow list #2696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/allow-list-ipv6
branch
from
f32dbe8 to
0fefcaa
Compare
Signed-off-by: Julius Härtl <[email protected]>
Member
Author
|
ping for review |
max-nextcloud
approved these changes
Jan 2, 2023
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Looks good.
Tests included... yay!
Member
Author
|
/backport 016c3ac to stable25 |
Member
Author
|
/backport 016c3ac to stable24 |
Member
Author
|
/backport 016c3ac to stable23 |
This was referenced Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring is kept separate so we can backport the fix to older releases since symfony/http-foundation is only available since 25: nextcloud/3rdparty#1102
Checklist