Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Nov 7, 2025

Else, the user completely lose the target album and its content.

@artonge artonge self-assigned this Nov 7, 2025
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Nov 7, 2025
@artonge artonge added this to the Nextcloud 33 milestone Nov 7, 2025
@artonge
Copy link
Collaborator Author

artonge commented Nov 7, 2025

/backport to stable32

@artonge
Copy link
Collaborator Author

artonge commented Nov 7, 2025

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Nov 7, 2025
@artonge
Copy link
Collaborator Author

artonge commented Nov 7, 2025

/backport to stable30

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.21%. Comparing base (5340223) to head (f1ba25f).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3270   +/-   ##
======================================
  Coverage    2.21%   2.21%           
======================================
  Files         107     107           
  Lines        6586    6586           
  Branches      121     121           
======================================
  Hits          146     146           
  Misses       6435    6435           
  Partials        5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge
Copy link
Collaborator Author

artonge commented Nov 7, 2025

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge requested review from skjnldsv and susnux November 7, 2025 10:12
@artonge artonge added the feature: albums Related to the albums section label Nov 7, 2025
@skjnldsv skjnldsv merged commit fb22e6c into master Nov 7, 2025
47 checks passed
@skjnldsv skjnldsv deleted the artonge/fix/album_move_overwrite branch November 7, 2025 10:20
@backportbot
Copy link

backportbot bot commented Nov 7, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3270/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0599a17a f1ba25f8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3270/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented Nov 7, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/3270/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0599a17a f1ba25f8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3270/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@tobiasKaminsky
Copy link
Member

@artonge backport to 30 seems to fail, which is required by the requester/customer.

@artonge
Copy link
Collaborator Author

artonge commented Nov 10, 2025

@tobiasKaminsky ir was done from 31: #3273

@tobiasKaminsky
Copy link
Member

Perfect. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot bug Something isn't working feature: albums Related to the albums section javascript Javascript related ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants