Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 13, 2025

Currently it is not possible to install the dependencies in offline mode:

$ npm cache clean -f && npm ci --offline
npm warn using --force Recommended protections disabled.
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@nextcloud/[email protected]',
npm warn EBADENGINE   required: { node: '^20.0.0', npm: '^10.0.0' },
npm warn EBADENGINE   current: { node: 'v22.17.1', npm: '10.9.2' }
npm warn EBADENGINE }
...
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@nextcloud/[email protected]',
npm warn EBADENGINE   required: { node: '^20.0.0' },
npm warn EBADENGINE   current: { node: 'v22.17.1', npm: '10.9.2' }
npm warn EBADENGINE }
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/yocto-queue/-/yocto-queue-0.1.0.tgz failed: cache mode is 'only-if-cached' but no cached response is available.

Having the resolved and integrity fields is important to ensure the app can be built reproducible and that all dependencies are not corrupted. I added the missing fields using https://www.npmjs.com/package/npm-package-lock-add-resolved.
Also see npm/cli#4460.

@provokateurin provokateurin added this to the Nextcloud 33 milestone Sep 13, 2025
@provokateurin provokateurin requested review from a team, sorbaugh, susnux and szaimen and removed request for a team September 13, 2025 15:48
@provokateurin provokateurin added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Sep 13, 2025
@provokateurin
Copy link
Member Author

/backport to stable32

@provokateurin
Copy link
Member Author

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 13, 2025
@provokateurin
Copy link
Member Author

/backport to stable30

@codecov
Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.23%. Comparing base (c25e318) to head (a7e1a6d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3178   +/-   ##
======================================
  Coverage    2.23%   2.23%           
======================================
  Files         107     107           
  Lines        6519    6519           
  Branches      121     121           
======================================
  Hits          146     146           
  Misses       6368    6368           
  Partials        5       5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@provokateurin provokateurin merged commit bd5b006 into master Sep 13, 2025
48 checks passed
@provokateurin provokateurin deleted the chore/deps/package-lock-json-add-missing-resolved-integrity branch September 13, 2025 16:11
@backportbot
Copy link

backportbot bot commented Sep 13, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3178/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a7e1a6db

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3178/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

Apparently stable30 isn't affected, so no manual backport either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants