Fix scrolling in large folders

[starypatyk]

When a folder contains over ~100 files or sub-folders (exact number seems to depend on the browser windows size), only a first batch of files/sub-folders is displayed. Empty space is shown when scrolling further down. This has been described in #1540 and likely also in #1490.

This seems to be the same issue as the one described in the vue-virtual-grid repository: Mikescops/vue-virtual-grid#25

The fix provided there (Mikescops/vue-virtual-grid#26) introduces a new property: scrollElement that should be set to an appropriate element on the page - i.e. the scrolling container.

In this PR I propose a fix implemented similarly to what is used e.g. in FaceContent.vue:

photos/src/views/FaceContent.vue

Line 127 in 65d222d

:container-element="appContent"

photos/src/views/FaceContent.vue

Line 251 in 65d222d

appContent: document.getElementById('app-content-vue'),

[artonge]

If this fix the issue in your testing, then it looks fine :)

[starypatyk]

Hi @artonge,

Great to see the fix merged into master. 👍

Would you consider backporting it to stable26 and stable25?

The change applies cleanly to both these branches (except compiled JS of course). Pre-requisites are also there - i.e. the required element on the page and appropriate version of the vue-virtual-grid library.

I suspect I could invoke the nextcloud-bot myself, but I am not sure if this is an accepted practice for external contributors.

[skjnldsv]

/backport to stable26

[skjnldsv]

/backport to stable25

[artonge]

I suspect I could invoke the nextcloud-bot myself, but I am not sure if this is an accepted practice for external contributors.

Stumbling on that, and it looks like we did not answer you. Feel free to use the backport bot next time if you feel like it is needed. In any case, the generated PRs will need to go through another round of approval ;).

[starypatyk]

Thanks @artonge! As another PR is in progress, I will probably use it soon. 😉