Skip to content

By default enable HIBP check #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rullzer wants to merge 3 commits into from
Closed

By default enable HIBP check #148

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2868152
By default enable HIBP check
rullzer Apr 12, 2021
c735836
Disable HIPB if the server has no internet connection
LukasReschke May 25, 2021
e2ce0ac
Fix code style
MorrisJobke May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/PasswordPolicyConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,15 @@ public function setEnforceSpecialCharacters(bool $enforceSpecialCharacters) {
* @return bool
*/
public function getEnforceHaveIBeenPwned(): bool {
$hasInternetConnection = $this->config->getSystemValue('has_internet_connection', true);
if(!$hasInternetConnection) {
return false;
}

return $this->config->getAppValue(
'password_policy',
'enforceHaveIBeenPwned',
'0'
'1'
) === '1';
}

Expand Down