Request the permissions for notifications via user interaction #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
force-pushed
the
bugfix/noid/web-notifications
branch
from
870222d to
ac2cf6f
Compare
ChristophWurst
approved these changes
Mar 4, 2020
Member
|
/compile amend / |
Signed-off-by: Joas Schilling <[email protected]> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
bugfix/noid/web-notifications
branch
from
ac2cf6f to
05be546
Compare
juliusknorr
approved these changes
Mar 4, 2020
Member
Author
|
/backport to stable18 |
|
The backport to stable18 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know when this started, but it seems browsers nowerdays only allow to request notification permissions in active tasks shortly after human interaction (Firefox wording below):
To test click on the icon next to the URL input of your browser and remove the notification permission manually.
So to make this work again, we show a red dot when no permission decision was made yet.
Then when you click on the button, we show a message
Requesting browser permissions to show notificationswhile doing that. Afterwards everything will just work fine again.I think we should backport this at least to all versions as long as the patch applies.