fix: method signature #52
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
After the PR nextcloud/server#48219 the signatore of this method was changed and now is necessary to have return typing. Problem fixed: ``` Declaration of OCA\\GroupQuota\\Wrapper\\GroupQuotaWrapper::getCache($path = '', $storage = null) must be compatible with OC\\Files\\Storage\\Wrapper\\Wrapper::getCache($path = '', $storage = null): OCP\\Files\\Cache\\ICache at /var/www/html/apps-writable/groupquota/lib/Wrapper/GroupQuotaWrapper.php#35 ``` Server version affected: >= 31 Signed-off-by: Vitor Mattos <[email protected]>
icewind1991
force-pushed
the
fix/method-signature
branch
from
51c5a92 to
e96e7b2
Compare
|
Thanks |
2 participants
After the PR nextcloud/server#48219 the signatore of this method was changed and now is necessary to have return typing.
Problem fixed:
Server version affected: >= 31