-
Notifications
You must be signed in to change notification settings - Fork 17
internal link across global scale #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58f2551 to
26981b7
Compare
26981b7 to
c04e3fb
Compare
d0537e5 to
7fd06b3
Compare
7fd06b3 to
60f5106
Compare
ed2d615 to
bd96e25
Compare
Member
Author
|
All use cases has been tested and are fully working. last task before merge:
|
bd96e25 to
8e7e0a1
Compare
come-nc
reviewed
Oct 7, 2025
51727db to
099dc62
Compare
099dc62 to
578b717
Compare
come-nc
reviewed
Oct 13, 2025
CarlSchwan
reviewed
Oct 14, 2025
4012772 to
f08e3ce
Compare
f8532e7 to
3cd348b
Compare
Signed-off-by: Maxence Lange <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
3cd348b to
9b7f072
Compare
aeb5248 to
f76bfc0
Compare
CarlSchwan
approved these changes
Jan 14, 2026
4b2958e to
51df6aa
Compare
Signed-off-by: Maxence Lange <[email protected]>
51df6aa to
f8cd96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support the Internal Link feature while using global scale.
Internal links generated on one instance should be able to link to the correct (local/shared) file when used by an other account from another instance within the same global scale.
synopsis
1. identity token
2. internal link
https://nc1.example.net/gf/<token>/<fileid>/gf/<token>/<fileid>while navigating on the (slave) instance forwarded user has its account.3. search
Expected behavior
Concept can be fully approached with a 3 instances setup:
link1
link2
link3
Tested use cases:
To complete those cases:
user shares
team shares
requirements
manual testing
./occ globalsiteselector:discoveryon every instance of the globalscale./occ globalsiteselector:discovery --currentto display list of globalscale identity tokenhttps://nc1.example.net/gf/<token>/<fileid>