This repository was archived by the owner on May 28, 2024. It is now read-only.
Prevent video file downloads when there is a download limit#274
Merged
Prevent video file downloads when there is a download limit#274
Conversation
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/compile amend / |
Signed-off-by: Christopher Ng <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/download-limit
branch
from
48537c3 to
be80e55
Compare
CarlSchwan
approved these changes
May 5, 2022
This was referenced May 5, 2022
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional requests to the file download endpoint on video preload would be made which would count against the download limit
Since videos with a download limit are non-interactive and can't be played, see nextcloud/files_downloadlimit#76, we don't add the source element with the src video URL on the video player to prevent undesired preloads and therefore downloads of the download limited file