-
Notifications
You must be signed in to change notification settings - Fork 6
fixed the issue to accept 0 and null and changed the default text value to remaining downloads #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
1bf86a3
806e7bb
0b3d05c
e14e219
cfbe4c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,8 +48,8 @@ export default class DownloadLimitAction { | |
| icon: 'icon-download', | ||
| is: this._store.enabled ? ActionInput : null, | ||
| text: t('files_downloadlimit', 'Download limit'), | ||
| title: t('files_downloadlimit', 'Download count: {count}', this._store), | ||
| value: this._store.limit, | ||
| title: t('files_downloadlimit', 'Downloads: {count}', this._store), | ||
| value: this._store.limit ? this._store.limit - this._store.count : this._store.limit, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure this change makes sense, the label says download limit so it should show the limit, not something else.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It makes sense because the remaining downloads is the current download limit. To show the initial download limit one week later to the customer does not deliver any new information to the user because he may remember the initial download limit or can calculate it with the download counter. It is more helpful to tell the user the current download limit to enable him to decide if he wants to increase it or not. |
||
| } | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.