enh(utility): add timezone generator method to ITimeFactory #11538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested changes
Feb 13, 2024
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Timezone is not part of https://www.php-fig.org/psr/psr-20/#21-clockinterface
Not sure where, but this should go somewhere else
Contributor
Author
I guess it could go into the changed APIs documentation? |
miaulalala
force-pushed
the
enh/add-timezone-generator
branch
from
3ab1e33 to
3752cf2
Compare
miaulalala
force-pushed
the
enh/add-timezone-generator
branch
from
3752cf2 to
ca32ece
Compare
Member
|
I would put it somewhere under https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/index.html. Upgrade docs are only there to highlight changes |
miaulalala
force-pushed
the
enh/add-timezone-generator
branch
from
ca32ece to
fa581ba
Compare
ChristophWurst
approved these changes
Mar 5, 2024
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
enh/add-timezone-generator
branch
from
eb7f161 to
f76fc77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for nextcloud/server#41300