Skip to content

Alway add the item at the end of the layout.#5595

Merged
mgallien merged 1 commit into
masterfrom
bugfix/use-vfs-ui
Apr 12, 2023
Merged

Alway add the item at the end of the layout.#5595
mgallien merged 1 commit into
masterfrom
bugfix/use-vfs-ui

Conversation

@camilasan

@camilasan camilasan commented Apr 11, 2023

Copy link
Copy Markdown
Member

Before:
vfs-ui

After:
vfs-ui-after

@camilasan

camilasan commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

/backport to stable-3.8

@codecov

codecov Bot commented Apr 12, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5595 (6a4d6b9) into master (6b87324) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5595      +/-   ##
==========================================
+ Coverage   59.23%   59.25%   +0.01%     
==========================================
  Files         143      143              
  Lines       18437    18437              
==========================================
+ Hits        10922    10924       +2     
+ Misses       7515     7513       -2

see 1 file with indirect coverage changes

@mgallien
Alway add the item at the end of the layout.
6a4d6b9 
Signed-off-by: Camila <hello@camila.codes>
@mgallien mgallien force-pushed the bugfix/use-vfs-ui branch from ecf5cd5 to 6a4d6b9 Compare April 12, 2023 08:16
@nextcloud-desktop-bot

nextcloud-desktop-bot commented Apr 12, 2023

Copy link
Copy Markdown

AppImage file: nextcloud-PR-5595-6a4d6b9c974a4a9a47fbe4520ed721e4fdaa4a12-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Apr 12, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mgallien mgallien merged commit d5bddb9 into master Apr 12, 2023
@mgallien mgallien deleted the bugfix/use-vfs-ui branch April 12, 2023 11:43
@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Apr 12, 2023
Merged
@mgallien mgallien added this to the 3.9.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claucambra claucambra claucambra approved these changes
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
+1 more reviewer
@allexzander allexzander allexzander approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@camilasan @nextcloud-desktop-bot @allexzander @claucambra @mgallien