use new connect syntax#5451
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5451 +/- ##
=======================================
Coverage 57.83% 57.83%
=======================================
Files 141 141
Lines 18149 18149
=======================================
+ Hits 10496 10497 +1
+ Misses 7653 7652 -1
|
claucambra
requested changes
Feb 20, 2023
claucambra
left a comment
claucambra
left a comment
Collaborator
There was a problem hiding this comment.
Small comments but worth addressing
mgallien
force-pushed
the
bugfix/connectNormalizedArgs
branch
from
c6cf023 to
a5aac28
Compare
claucambra
approved these changes
Feb 23, 2023
mgallien
force-pushed
the
bugfix/connectNormalizedArgs
branch
from
a5aac28 to
34e3991
Compare
mainly done using clazy and old-style-connect check close #5426 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/connectNormalizedArgs
branch
from
34e3991 to
01ecb63
Compare
|
SonarCloud Quality Gate failed. |
allexzander
approved these changes
Feb 28, 2023
|
AppImage file: nextcloud-PR-5451-01ecb639abd20f1eb72e153d1f8bf0440183d159-x86_64.AppImage |
Collaborator
Author
|
/backport to stable-3.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainly done using clazy and old-style-connect check
close #5426