Ci/clang tidy checks init variables#5436
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5436 +/- ##
==========================================
- Coverage 57.83% 57.82% -0.01%
==========================================
Files 141 141
Lines 18146 18147 +1
==========================================
- Hits 10495 10494 -1
- Misses 7651 7653 +2
|
mgallien
force-pushed
the
ci/clangTidyChecksInitVariables
branch
2 times, most recently
from
ab1a438 to
bff04bc
Compare
claucambra
requested changes
Feb 20, 2023
mgallien
force-pushed
the
ci/clangTidyChecksInitVariables
branch
from
bff04bc to
3e6fcb6
Compare
claucambra
approved these changes
Feb 21, 2023
mgallien
force-pushed
the
ci/clangTidyChecksInitVariables
branch
3 times, most recently
from
4adfab0 to
94c6f20
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
done with clang-tidy
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-auto' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
using a static_cast like this means that the compiler will not check the
validity of the cast
this could lead now or later to crash and other issues if the real type
is not the one in the cast
done with clang-tidy
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
fix windows specific code compilation warnings Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
ci/clangTidyChecksInitVariables
branch
from
94c6f20 to
151d17a
Compare
|
AppImage file: nextcloud-PR-5436-151d17aed4554971e3d223a5ba54856c1f8098ef-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Collaborator
Author
|
/backport to stable-3.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.