Skip to content

Revert "Merge pull request #5366 from nextcloud/bugfix/remove-mono-icons-setting"#5372

Merged
claucambra merged 1 commit into
masterfrom
bugfix/revert-mono-config-delete
Jan 27, 2023
Merged

Revert "Merge pull request #5366 from nextcloud/bugfix/remove-mono-icons-setting"#5372
claucambra merged 1 commit into
masterfrom
bugfix/revert-mono-config-delete

Conversation

@claucambra

Copy link
Copy Markdown
Collaborator

This reverts commit 5c42da4, reversing changes made to e4b2449.

Caused issues on macOS, will find a better way to remove the monochrome icons option when it does nothing

…ons-setting"

This reverts commit 5c42da4, reversing
changes made to e4b2449.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/revert-mono-config-delete branch from 6a5bef2 to 68c785e Compare January 27, 2023 11:23
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: nextcloud-PR-5372-68c785e25c278ba37084846c6060c644cbec48f0-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov

codecov Bot commented Jan 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5372 (68c785e) into master (e332929) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5372   +/-   ##
=======================================
  Coverage   58.29%   58.30%           
=======================================
  Files         141      141           
  Lines       17990    18008   +18     
=======================================
+ Hits        10488    10499   +11     
- Misses       7502     7509    +7     
Impacted Files Coverage Δ
src/libsync/configfile.cpp 28.76% <0.00%> (+1.49%) ⬆️
src/libsync/theme.cpp 16.88% <0.00%> (-0.33%) ⬇️
src/libsync/theme.h 50.00% <ø> (ø)

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 12 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 9cb1609 into master Jan 27, 2023
@claucambra claucambra deleted the bugfix/revert-mono-config-delete branch January 27, 2023 12:16
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants