Skip to content

Always unlock E2EE folders, even when network failure or crash.#5370

Merged
mgallien merged 1 commit into
masterfrom
feature/e2ee-folders-unlock-always
Jan 30, 2023
Merged

Always unlock E2EE folders, even when network failure or crash.#5370
mgallien merged 1 commit into
masterfrom
feature/e2ee-folders-unlock-always

Conversation

@allexzander

Copy link
Copy Markdown
Contributor

Signed-off-by: alex-z blackslayer4@gmail.com

@allexzander allexzander marked this pull request as ready for review January 26, 2023 16:03
@allexzander allexzander force-pushed the feature/e2ee-folders-unlock-always branch from ee0d8d6 to f593abc Compare January 26, 2023 16:20
@codecov

codecov Bot commented Jan 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #5370 (f593abc) into master (a7013c5) will decrease coverage by 0.20%.
The diff coverage is 12.71%.

❗ Current head f593abc differs from pull request most recent head bd9eb0c. Consider uploading reports for the commit bd9eb0c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5370      +/-   ##
==========================================
- Coverage   58.24%   58.04%   -0.20%     
==========================================
  Files         141      141              
  Lines       18006    18095      +89     
==========================================
+ Hits        10488    10504      +16     
- Misses       7518     7591      +73     
Impacted Files Coverage Δ
src/common/preparedsqlquerymanager.h 0.00% <ø> (ø)
src/common/syncjournaldb.h 66.66% <ø> (ø)
...libsync/abstractpropagateremotedeleteencrypted.cpp 0.00% <0.00%> (ø)
src/libsync/clientsideencryption.cpp 26.84% <0.00%> (-0.59%) ⬇️
src/libsync/clientsideencryption.h 33.33% <ø> (ø)
src/libsync/clientsideencryptionjobs.cpp 8.73% <0.00%> (-1.10%) ⬇️
src/libsync/clientsideencryptionjobs.h 0.00% <ø> (ø)
src/libsync/encryptfolderjob.cpp 0.00% <0.00%> (ø)
src/libsync/propagateuploadencrypted.cpp 0.00% <0.00%> (ø)
src/libsync/syncengine.cpp 81.01% <22.22%> (-0.41%) ⬇️
... and 7 more

Comment thread src/libsync/clientsideencryptionjobs.cpp Outdated
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/e2ee-folders-unlock-always branch from f593abc to bd9eb0c Compare January 30, 2023 15:01
@allexzander allexzander requested a review from mgallien January 30, 2023 15:01
@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

11.4% 11.4% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit bfc80d2 into master Jan 30, 2023
@mgallien mgallien deleted the feature/e2ee-folders-unlock-always branch January 30, 2023 15:46
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: nextcloud-PR-5370-bd9eb0c89f4d22478d960930a591899bfad5f15f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
TSI-pranalideshpande added a commit to nextmcloud/desktop that referenced this pull request Feb 3, 2023
…n network

failure or crash is merged for mac
TSI-parulsharma added a commit to nextmcloud/desktop that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants