Skip to content

Feature/allow forceoverrideurl via command line#5329

Merged
allexzander merged 1 commit into
masterfrom
feature/allow-forceoverrideurl-via-command-line
Jan 17, 2023
Merged

Feature/allow forceoverrideurl via command line#5329
allexzander merged 1 commit into
masterfrom
feature/allow-forceoverrideurl-via-command-line

Conversation

@allexzander

@allexzander allexzander commented Jan 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@allexzander allexzander force-pushed the feature/allow-forceoverrideurl-via-command-line branch 2 times, most recently from 55056f5 to 2da5a25 Compare January 13, 2023 20:33
@allexzander allexzander reopened this Jan 17, 2023
@codecov

codecov Bot commented Jan 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5329 (fe0bd83) into master (382b322) will decrease coverage by 0.11%.
The diff coverage is 5.26%.

❗ Current head fe0bd83 differs from pull request most recent head 2bd1c27. Consider uploading reports for the commit 2bd1c27 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5329      +/-   ##
==========================================
- Coverage   57.59%   57.48%   -0.11%     
==========================================
  Files         139      139              
  Lines       17631    17667      +36     
==========================================
+ Hits        10154    10156       +2     
- Misses       7477     7511      +34
Impacted Files Coverage Δ
src/libsync/configfile.cpp 25.04% <0.00%> (-0.70%) ⬇️
src/libsync/theme.cpp 16.88% <4.76%> (-0.44%) ⬇️
src/libsync/theme.h 50.00% <100.00%> (+16.66%) ⬆️

@allexzander allexzander marked this pull request as ready for review January 17, 2023 15:46
camilasan
camilasan requested changes Jan 17, 2023
View reviewed changes
Comment thread src/libsync/configfile.cpp
@allexzander
Allow specifying the server force override URL and local sync folder …
2bd1c27 
…path via command line.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/allow-forceoverrideurl-via-command-line branch from fe0bd83 to 2bd1c27 Compare January 17, 2023 16:27
@allexzander allexzander requested a review from camilasan January 17, 2023 16:27
@sonarqubecloud

sonarqubecloud Bot commented Jan 17, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

1.3% 1.3% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot

nextcloud-desktop-bot commented Jan 17, 2023

Copy link
Copy Markdown

AppImage file: nextcloud-PR-5329-2bd1c272a6a067b5d039e8e676bb1932c85a5f01-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 4ee22a9 into master Jan 17, 2023
@allexzander allexzander deleted the feature/allow-forceoverrideurl-via-command-line branch January 17, 2023 17:18
@allexzander

allexzander commented Jan 17, 2023

Copy link
Copy Markdown
Contributor Author

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Jan 17, 2023
Merged
1 task
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
@camilasan camilasan mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilasan camilasan camilasan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@allexzander @nextcloud-desktop-bot @camilasan @mgallien