Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists#5291
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5291 +/- ##
==========================================
- Coverage 57.59% 57.52% -0.08%
==========================================
Files 139 139
Lines 17596 17596
==========================================
- Hits 10135 10122 -13
- Misses 7461 7474 +13
|
mgallien
approved these changes
Dec 20, 2022
… if file exists, as it is faster Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
mgallien
force-pushed
the
bugfix/qfileinfo-exists
branch
from
3bbd1d6 to
f6c4c32
Compare
|
AppImage file: nextcloud-PR-5291-f6c4c32b6e25948c8782ca08f27d6285ca1ee796-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QFileInfo::exists is faster
Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com