Fix tray window margins, stop cutting into window border#5202
Merged
Conversation
allexzander
approved these changes
Nov 24, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/tray-window-margins
branch
from
bfad848 to
9a01480
Compare
|
AppImage file: nextcloud-PR-5202-9a01480fcc5039b245fb59046828bc65614b29c8-x86_64.AppImage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment we respect the tray window's margins in a very ad-hoc way, leading to small breakages and visual bugs (such as the header eating into the background border)
This PR properly addresses the sizing of the window contents
With fix:
Before fix:
Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com