Skip to content

Make user status selector modal, show user header#5145

Merged
claucambra merged 1 commit into
masterfrom
feature/userstatusselector-modal
Nov 9, 2022
Merged

Make user status selector modal, show user header#5145
claucambra merged 1 commit into
masterfrom
feature/userstatusselector-modal

Conversation

@claucambra

Copy link
Copy Markdown
Collaborator

Per the design discussion

Screen.Recording.2022-11-09.at.14.09.56.mov

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/userstatusselector-modal branch from 83690ab to 8315770 Compare November 9, 2022 16:39
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: nextcloud-PR-5145-8315770467c31198785fa1b58e760303b2c568b8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit de7976e into master Nov 9, 2022
@claucambra claucambra deleted the feature/userstatusselector-modal branch November 9, 2022 17:16
@mgallien mgallien added this to the 3.7.0 milestone Nov 24, 2022
@claucambra

Copy link
Copy Markdown
Collaborator Author

Need to backport as this fixes a polish loop in 3.6+

@claucambra

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants