Add interactive NC Talk notifications on macOS#5143
Merged
Conversation
claucambra
force-pushed
the
feature/interactive-talk-macos-notifications
branch
from
87478c2 to
f3f35b8
Compare
claucambra
force-pushed
the
feature/interactive-talk-macos-notifications
branch
from
f3f35b8 to
1755658
Compare
allexzander
approved these changes
Dec 9, 2022
claucambra
force-pushed
the
feature/interactive-talk-macos-notifications
branch
from
1755658 to
3e47e9e
Compare
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…cOS text reply notifications Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
feature/interactive-talk-macos-notifications
branch
from
3e47e9e to
4a42aee
Compare
|
AppImage file: nextcloud-PR-5143-4a42aee17e0ace308940a9ebfdba456aedc4d8ad-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the client differentiate between normal notifications and Talk notifications, emitting reply-able notifications for Talk on macOS
Screen.Recording.2022-11-08.at.19.17.11.mov
Closes #4851
Interested parties: @jospoortvliet :)