Skip to content

Do not format text in QML components as HTML#4944

Merged
claucambra merged 1 commit into
masterfrom
bugfix/html-enabled-text-qml
Sep 17, 2022
Merged

Do not format text in QML components as HTML#4944
claucambra merged 1 commit into
masterfrom
bugfix/html-enabled-text-qml

Conversation

@claucambra

@claucambra claucambra commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

Not a source of any vulnerabilities as the supported subset of HTML is very limited (see https://doc.qt.io/qt-5/richtext-html-subset.html) but should still eliminate any potential weirdness

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@codecov

codecov Bot commented Sep 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4944 (547e5a4) into master (1382e4c) will decrease coverage by 0.15%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4944      +/-   ##
==========================================
- Coverage   57.14%   56.99%   -0.16%     
==========================================
  Files         138      138              
  Lines       17232    17232              
==========================================
- Hits         9848     9821      -27     
- Misses       7384     7411      +27     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/filesystem.cpp 73.11% <0.00%> (-3.23%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.95% <0.00%> (-2.47%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.83% <0.00%> (-1.83%) ⬇️
src/libsync/syncengine.cpp 85.02% <0.00%> (-0.54%) ⬇️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/html-enabled-text-qml branch from bab91a9 to 547e5a4 Compare September 17, 2022 13:05
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: nextcloud-PR-4944-547e5a46755e3bd766e1ac47685de344ac4540ef-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 7397d99 into master Sep 17, 2022
@claucambra claucambra deleted the bugfix/html-enabled-text-qml branch September 17, 2022 21:55
@claucambra

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.6

1 similar comment
@claucambra

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants