Fix ActivityItem activityHover error#4921
Merged
Merged
Conversation
Collaborator
Author
|
No need to backport as the change that brought this about was not backported |
Codecov Report
@@ Coverage Diff @@
## master #4921 +/- ##
==========================================
- Coverage 57.21% 57.19% -0.03%
==========================================
Files 138 138
Lines 17136 17136
==========================================
- Hits 9805 9801 -4
- Misses 7331 7335 +4
|
mgallien
approved these changes
Sep 10, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
mgallien
force-pushed
the
bugfix/activity-item-error
branch
from
a210241 to
871ad24
Compare
|
AppImage file: nextcloud-PR-4921-871ad24e28d74b4bee3fb9077a42c5df67e9df53-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ActivityItem'smoreActionsButtonstill pulls its colour from an item that now no longer exists, hence the errorSince we don't want it to have a background anyway, at least not when it isn't hovered, there is no need to set this value as internally in
ActivityItemActionsit is set totransparent, which is what we want anywaySigned-off-by: Claudio Cambra claudio.cambra@gmail.com