Skip to content

Bugfix/selective sync abort error#4903

Merged
allexzander merged 3 commits into
masterfrom
bugfix/selective-sync-abort-error
Sep 7, 2022
Merged

Bugfix/selective sync abort error#4903
allexzander merged 3 commits into
masterfrom
bugfix/selective-sync-abort-error

Conversation

@allexzander

@allexzander allexzander commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

This will fix #4895

@codecov

codecov Bot commented Sep 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4903 (7e53280) into master (66effe1) will decrease coverage by 0.03%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
- Coverage   57.18%   57.15%   -0.04%     
==========================================
  Files         138      138              
  Lines       17133    17135       +2     
==========================================
- Hits         9798     9793       -5     
- Misses       7335     7342       +7     
Impacted Files Coverage Δ
src/libsync/syncengine.cpp 87.20% <50.00%> (-0.03%) ⬇️
src/libsync/owncloudpropagator.cpp 86.02% <100.00%> (+0.02%) ⬆️
src/libsync/owncloudpropagator.h 74.43% <100.00%> (+1.15%) ⬆️
src/libsync/propagateuploadng.cpp 82.39% <0.00%> (-1.50%) ⬇️
src/libsync/propagateremotemkdir.cpp 64.53% <0.00%> (-0.71%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.20% <0.00%> (-0.46%) ⬇️
src/libsync/propagatedownload.cpp 64.88% <0.00%> (-0.15%) ⬇️

@allexzander allexzander force-pushed the bugfix/selective-sync-abort-error branch from ccfaac0 to 5fd89fa Compare September 7, 2022 08:27
…not displayed in UI.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/selective-sync-abort-error branch from ae84448 to 73ebbf8 Compare September 7, 2022 10:35
@allexzander allexzander marked this pull request as ready for review September 7, 2022 10:36
Signed-off-by: alex-z <blackslayer4@gmail.com>
…ync.

Signed-off-by: allexzander <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/selective-sync-abort-error branch from 73ebbf8 to 7e53280 Compare September 7, 2022 10:38
@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2022

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: nextcloud-PR-4903-7e53280de6a80fe326fc99ca79febc297fee29f9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 926256d into master Sep 7, 2022
@allexzander allexzander deleted the bugfix/selective-sync-abort-error branch September 7, 2022 12:31
@allexzander

Copy link
Copy Markdown
Contributor Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Changing the list of synced folders is being reported as an error

4 participants