Skip to content

Ensure file activity dialog is centered on screen and appears at top of window stack#4853

Merged
claucambra merged 1 commit into
masterfrom
bugfix/file-activity-window-position
Aug 17, 2022
Merged

Ensure file activity dialog is centered on screen and appears at top of window stack#4853
claucambra merged 1 commit into
masterfrom
bugfix/file-activity-window-position

Conversation

@claucambra

@claucambra claucambra commented Aug 16, 2022

Copy link
Copy Markdown
Collaborator

This should fix the file activity dialog window appearing underneath other windows and in weird places

@karlitschek

With fix:

Screen.Recording.2022-08-17.at.13.31.50.mov

Master:

Screen.Recording.2022-08-17.at.13.36.35.mov

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Aug 16, 2022
@codecov

codecov Bot commented Aug 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4853 (2ab95a3) into master (1e7fb93) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4853      +/-   ##
==========================================
+ Coverage   57.21%   57.23%   +0.01%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
+ Hits         9809     9812       +3     
+ Misses       7335     7332       -3     
Impacted Files Coverage Δ
src/libsync/discovery.cpp 84.86% <0.00%> (+0.29%) ⬆️

@karlitschek

Copy link
Copy Markdown
Member

👍

@AndyScherzinger

Copy link
Copy Markdown
Member

💙

…of window stack

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/file-activity-window-position branch from 14cab5e to 2ab95a3 Compare August 17, 2022 12:01
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: Nextcloud-PR-4853-2ab95a30f9e6289469d17047bc527f3338f94b16-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 6746717 into master Aug 17, 2022
@claucambra claucambra deleted the bugfix/file-activity-window-position branch August 17, 2022 13:30
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants