Make activity action button an actual button, clean up contents

[claucambra]

This should make the behaviour of this component much more predictable

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[codecov]

Codecov Report

Merging #4784 (db861e1) into master (a4dde43) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4784      +/-   ##
==========================================
- Coverage   57.12%   57.10%   -0.02%     
==========================================
  Files         138      138              
  Lines       17230    17230              
==========================================
- Hits         9842     9839       -3     
- Misses       7388     7391       +3     

Impacted Files	Coverage Δ
src/libsync/discovery.cpp	83.95% <0.00%> (-0.30%)	⬇️
src/libsync/propagatedownload.cpp	64.61% <0.00%> (ø)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[allexzander]

@claucambra Buttons in this new version look kinda off. They look huge. Maybe you need to ask @jancborchardt or @nimishavijay for review.

Here is how they look for me with these changes:

And here is the old look:

[claucambra]

@claucambra Buttons in this new version look kinda off. They look huge. Maybe you need to ask @jancborchardt or @nimishavijay for review.

Here is how they look for me with these changes:

And here is the old look:

Yes, the buttons have changed height but this is actually their intended behaviour. Some change to CustomButton overrode the height set to the ActivityActionButton, which is in QML set to be this big button size

The underline of the text buttons looks weird, though, so I will take a look

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-4784-db861e1ade541a4a1bd979538919fff1dd517b55-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information