Stop clearing notifications when new notifications are received#4735
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4735 +/- ##
==========================================
+ Coverage 56.40% 56.54% +0.14%
==========================================
Files 138 138
Lines 17069 17069
==========================================
+ Hits 9628 9652 +24
+ Misses 7441 7417 -24
|
Collaborator
Author
|
/backport to stable-3.5 |
camilasan
approved these changes
Jul 18, 2022
allexzander
approved these changes
Jul 21, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/fix-disappearing-notifications
branch
from
9cdfc77 to
8dfe164
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: Nextcloud-PR-4735-8dfe1647ed4115ec6e0e29cb0a1e69ede3d859a1-x86_64.AppImage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With recent changes to notification handling we keep a set of already-notified notification ids and prevent these notifications from being emitted again
A hold-over from previous code is to clear all notifications and replace them with the new set of notifications. With the recent changes this causes a bug where all notifications except newly received ones are removed
This PR stops old notifications from being cleared