QML-ify the UserModel, use properties rather than setter methods#4710
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4710 +/- ##
==========================================
+ Coverage 56.43% 56.55% +0.12%
==========================================
Files 138 138
Lines 17070 17070
==========================================
+ Hits 9633 9654 +21
+ Misses 7437 7416 -21
|
camilasan
approved these changes
Jul 11, 2022
camilasan
left a comment
camilasan
left a comment
Member
There was a problem hiding this comment.
I think this is a really nice improvement :)
Member
|
/backport to stable-3.5 |
claucambra
force-pushed
the
bugfix/qmlify-usermodel
branch
from
cd60ff6 to
f5fc33f
Compare
mgallien
reviewed
Jul 15, 2022
claucambra
force-pushed
the
bugfix/qmlify-usermodel
branch
3 times, most recently
from
49e4b8e to
5401b85
Compare
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/qmlify-usermodel
branch
from
5401b85 to
539ba93
Compare
|
AppImage file: Nextcloud-PR-4710-539ba93fd167c63269cc7fc7cb157cd4143e130b-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make more use of properties over setter methods, move
Q_INVOKABLE voidmethods to slotsSigned-off-by: Claudio Cambra claudio.cambra@gmail.com