Skip to content

Limit concurrent notifications#4706

Merged
claucambra merged 2 commits into
masterfrom
bugfix/limit-concurrent-notifications
Jul 12, 2022
Merged

Limit concurrent notifications#4706
claucambra merged 2 commits into
masterfrom
bugfix/limit-concurrent-notifications

Conversation

@claucambra

Copy link
Copy Markdown
Collaborator

This PR condenses several notifications into a single notification with text "XX notifications" in cases where these notifications all arrive at the same time.

This resolves two problems:

  1. On KDE Plasma / Gnome there is a tendency for the user to get absolutely carpet bombed when starting up the client
  2. On macOS the system actively throttles our capability to display notifications when we submit too many notification requests within a certain timeframe

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jul 6, 2022
@codecov

codecov Bot commented Jul 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4706 (bc01db7) into master (ea0ab54) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4706      +/-   ##
==========================================
+ Coverage   56.40%   56.41%   +0.01%     
==========================================
  Files         138      138              
  Lines       17068    17068              
==========================================
+ Hits         9627     9629       +2     
+ Misses       7441     7439       -2     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 75.42% <0.00%> (+0.48%) ⬆️

Comment thread src/gui/tray/usermodel.cpp Outdated
@claucambra claucambra force-pushed the bugfix/limit-concurrent-notifications branch 2 times, most recently from fec318e to a07bdf5 Compare July 7, 2022 10:08
@camilasan

Copy link
Copy Markdown
Member

/backport to stable-3.5

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@camilasan camilasan force-pushed the bugfix/limit-concurrent-notifications branch from a07bdf5 to 7d08702 Compare July 12, 2022 18:24
@nextcloud-desktop-bot

Copy link
Copy Markdown

AppImage file: Nextcloud-PR-4706-bc01db7cfff19a910e7bc23b3233b43260c32d0c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 15b7ee4 into master Jul 12, 2022
@claucambra claucambra deleted the bugfix/limit-concurrent-notifications branch July 12, 2022 22:46
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable-3.5 failed. Please do this backport manually.

@claucambra

Copy link
Copy Markdown
Collaborator Author

/backport to stable-3.5

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable-3.5 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants