Add a custom back button to the account wizard's advanced setup page

[claucambra]

This PR adds a back button to the advanced setup page of the accounts wizard that returns the user to the beginning of the wizard.

Addresses a point in #4052

Screen.Recording.2022-06-30.at.14.27.58.mov

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[codecov]

Codecov Report

Merging #4686 (b6bc885) into master (dfe2ef8) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b6bc885 differs from pull request most recent head 5e67405. Consider uploading reports for the commit 5e67405 to get more accurate results

@@            Coverage Diff             @@
##           master    #4686      +/-   ##
==========================================
- Coverage   56.43%   56.42%   -0.01%     
==========================================
  Files         138      138              
  Lines       17068    17069       +1     
==========================================
  Hits         9632     9632              
- Misses       7436     7437       +1     

Impacted Files	Coverage Δ
src/libsync/discovery.cpp	84.56% <0.00%> (-0.30%)	⬇️
src/libsync/ocsprofileconnector.cpp	0.00% <0.00%> (ø)
src/libsync/account.cpp	36.99% <0.00%> (+0.38%)	⬆️
src/libsync/account.h	35.71% <0.00%> (+6.30%)	⬆️

[nimishavijay]

Looks great! I would suggest removing the arrow <
Edit: This is there is all the back buttons, so this is not an issue :)

A question: Is it not possible to navigate back to the page where you enter your server address? This navigates to the first setup screen

[jancborchardt]

Agree with @nimishavijay's feedback.

Adding:

• The "<" is there on all Back buttons in our app, or in macOS? Cause it seems odd indeed.
• The wording ahould rather be "Cancel" since at this stage one is already connected, and "Back" sounds less destructive.

[claucambra]

Agree with @nimishavijay's feedback.

Adding:

• The "<" is there on all Back buttons in our app, or in macOS? Cause it seems odd indeed.
• The wording ahould rather be "Cancel" since at this stage one is already connected, and "Back" sounds less destructive.

Ok, I renamed the button to "Cancel":

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4686-5e67405b45a0bc33f4c27bc03915a48c083815cc-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[claucambra]

/backport to stable-3.5