Remove tooltip because it is only repeating the label of the link.#4657
Merged
Conversation
camilasan
force-pushed
the
bugfix/accessibility
branch
from
270966e to
cd994d7
Compare
claucambra
approved these changes
Jun 21, 2022
camilasan
force-pushed
the
bugfix/accessibility
branch
from
cd994d7 to
93d5c77
Compare
Codecov Report
@@ Coverage Diff @@
## master #4657 +/- ##
=======================================
Coverage 56.42% 56.42%
=======================================
Files 138 138
Lines 17071 17071
=======================================
+ Hits 9632 9633 +1
+ Misses 7439 7438 -1
|
mgallien
approved these changes
Jun 22, 2022
camilasan
force-pushed
the
bugfix/accessibility
branch
2 times, most recently
from
1b01075 to
7823bec
Compare
It is bad for accessibility. Signed-off-by: Camila <hello@camila.codes>
mgallien
force-pushed
the
bugfix/accessibility
branch
from
7823bec to
7744ad2
Compare
|
AppImage file: Nextcloud-PR-4657-7744ad29a90e6271d3fc0a78b272c73809554a8a-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
/backport to stable-3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is bad for accessibility.
See @jancborchardt 's comment: #4641 (review)