Bugfix. Take root folder's files size into account when displaying the total size in selective sync dialog.#4532
Conversation
allexzander
changed the title
|
@mgallien FYI: The model of the SelectiveSyncWidget only contains a tree of folders (subfolders) with folder name and size, but, no information for files. I've tried to make the PR small and not affect the model. Let me know if you have a better idea. |
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
I am confused
in the screenshot I have seen the leaf folder have their size based only on their content
this PR is not really changing this ?
from user point of view the tree to select folder is a bit hard to use as you have not really a way to see how much space will be used by the selected folders
when you close this tree selector dialog, the computed size is great and that is working well
|
|
||
| void SelectiveSyncWidget::slotUpdateRootFolderFilesSize(const QStringList &subfolders) | ||
| { | ||
| const auto job = qobject_cast<LsColJob *>(sender()); |
There was a problem hiding this comment.
please add a check that job is not null
allexzander
force-pushed
the
bugfix/selective-sync-total-size-displayed
branch
from
eff821a to
0a43c18
Compare
|
/backport to stable-3.5 |
|
/rebase |
…e total size in selective sync dialog. Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander
force-pushed
the
bugfix/selective-sync-total-size-displayed
branch
from
0a43c18 to
101a92f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: Nextcloud-PR-4532-101a92faf395cd2b22cb45ac4d543c6779a995e2-x86_64.AppImage |
4 participants
Signed-off-by: alex-z blackslayer4@gmail.com