Fix crashing of finder sync extension caused by dispatch_source_cancel of nullptr#4520
Merged
Conversation
8 tasks
mgallien
approved these changes
May 13, 2022
allexzander
approved these changes
May 16, 2022
Collaborator
Author
|
/rebase |
…l of nullptr Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/findersync-crash-fix
branch
from
e2082ff to
683e779
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: Nextcloud-PR-4520-683e7794a38bb4b03203773bf4d88a88d5fb8f22-x86_64.AppImage |
Collaborator
Author
|
/backport to stable-3.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses crashing faced by some users of the Finder Sync extension. Stack traces indicate this crashing originates from a bad dispatch queue call, so we are guarding the calls to ensure they are only called if the
readSourceandwriteSourcequeues are not null.Addresses #4459