Skip to content

fix: share and assign team issue#7687

Merged
grnd-alt merged 1 commit into
mainfrom
fix-share-and-assign-team
Apr 23, 2026
Merged

fix: share and assign team issue#7687
grnd-alt merged 1 commit into
mainfrom
fix-share-and-assign-team

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

@luka-nextcloud luka-nextcloud commented Feb 26, 2026 •
edited
Loading

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this Feb 26, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Feb 26, 2026
@luka-nextcloud luka-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Feb 26, 2026
@luka-nextcloud luka-nextcloud force-pushed the fix-share-and-assign-team branch 2 times, most recently from 9771207 to d76c1bb Compare March 9, 2026 10:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84632 was 84323 (+0.36%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt
grnd-alt requested changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failing phpunit tests say findAll called more than once, we're already querying for all acls in line 117, why not store and use again

@luka-nextcloud luka-nextcloud force-pushed the fix-share-and-assign-team branch from d76c1bb to 1dcf3a1 Compare April 1, 2026 14:40
@luka-nextcloud
fix: share and assign team issue
42f1f7a 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the fix-share-and-assign-team branch from 1dcf3a1 to 42f1f7a Compare April 1, 2026 14:41
@luka-nextcloud luka-nextcloud requested a review from grnd-alt April 1, 2026 14:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96079 was 93102 (+3.19%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96070 was 93102 (+3.18%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@samin-z samin-z self-requested a review April 23, 2026 08:09
@grnd-alt grnd-alt merged commit aad6858 into main Apr 23, 2026
43 checks passed
@grnd-alt grnd-alt deleted the fix-share-and-assign-team branch April 23, 2026 13:12
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 23, 2026
@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

luka-nextcloud commented Apr 23, 2026

/backport to stable32

@luka-nextcloud
Copy link
Copy Markdown
Contributor Author

luka-nextcloud commented Apr 23, 2026

/backport to stable33

@backportbot backportbot Bot mentioned this pull request Apr 23, 2026
Draft
3 tasks
@backportbot backportbot Bot mentioned this pull request Apr 23, 2026
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@elzody elzody Awaiting requested review from elzody

@samin-z samin-z Awaiting requested review from samin-z

Assignees

@luka-nextcloud luka-nextcloud

Labels

3. to review bug

Projects

📝 Productivity team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

assignment of cards to circles (and groups)

2 participants

@luka-nextcloud @grnd-alt