Add search task type and provider only returning sources #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
enh/noid/search
branch
from
14f5ae9 to
aff80b8
Compare
kyteinsky
requested changes
May 26, 2025
kyteinsky
reviewed
May 27, 2025
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
all is good otherwise 🚀
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/search
branch
from
10c88dd to
baf465a
Compare
kyteinsky
approved these changes
May 27, 2025
Contributor
kyteinsky
left a comment
kyteinsky
left a comment
There was a problem hiding this comment.
psalm might be a little unhappy but I definitely am, thanks, works great 💚
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/search
branch
from
baf465a to
4e2df90
Compare
kyteinsky
approved these changes
May 28, 2025
kyteinsky
added a commit
to nextcloud/context_chat_backend
that referenced
this pull request
Jun 2, 2025
related changes: - nextcloud/context_chat#129 - nextcloud/assistant#241 --------- Signed-off-by: Anupam Kumar <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New task type+provider to search instead of asking a question.
For now it performs a classic query to the backend but only returns the sources.
This requires adjustments in the assistant's custom input and output forms:
@kyteinsky What do you think about only supporting "none" and "providers" for the scope type? I'm not sure it makes sense to search with context chat in a specific directory.