Skip to content

[stable7.3] feat: group multiple emails or phone numbers #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backportbot wants to merge 1 commit into
base: stable7.3
Choose a base branch
from
+30 −19
Open

[stable7.3] feat: group multiple emails or phone numbers #5053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 30 additions & 19 deletions src/components/ContactDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<!-- org, title -->
<template #subtitle>
<template v-if="isReadOnly">
<span v-html="formattedSubtitle" />

Check warning on line 51 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

'v-html' directive can lead to XSS attack
</template>
<template v-else>
<input id="contact-title"
Expand All @@ -71,35 +71,42 @@
</template>

<template #quick-actions>
<div v-if="!editMode && !loadingData">
<Actions :inline="6"
type="secondary">
<ActionButton v-if="isTalkEnabled && isInSystemAddressBook"
:aria-label="(t('contacts', 'Go to talk conversation'))"
:name="(t('contacts', 'Go to talk conversation'))"
class="icon-talk quick-action"
:href="callUrl" />
<ActionButton v-if="profilePageLink"
class="quick-action"
:aria-label="(t('contacts','View profile'))"
:name="(t('contacts','View profile'))"
:href="profilePageLink">
<template #icon>
<IconAccount :size="20" />
</template>
</ActionButton>
<div v-if="!editMode && !loadingData" class="quick-actions">
<NcButton v-if="isTalkEnabled && isInSystemAddressBook"
:aria-label="(t('contacts', 'Go to talk conversation'))"
:name="(t('contacts', 'Go to talk conversation'))"
class="icon-talk quick-action"
:href="callUrl" />
<NcButton v-if="profilePageLink"
class="quick-action"
:aria-label="(t('contacts','View profile'))"
:name="(t('contacts','View profile'))"
:href="profilePageLink">
<template #icon>
<IconAccount :size="20" />
</template>
</NcButton>
<Actions class="quick-action"
variant="secondary">
<template #icon>
<IconMail :size="20" />
</template>
<ActionLink v-for="emailAddress in emailAddressList"

Check warning on line 94 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Variable 'emailAddress' is already declared in the upper scope
:key="emailAddress"
class="quick-action"
:href="'mailto:' + emailAddress">
<template #icon>
<IconMail :size="20" />
</template>
{{ emailAddress }}
</ActionLink>
</Actions>
<Actions class="quick-action"
variant="secondary">
<template #icon>
<IconCall :size="20" />
</template>
<ActionLink v-for="phoneNumber in phoneNumberList"
:key="phoneNumber"
class="quick-action"
:href="'tel:' + phoneNumber">
<template #icon>
<IconCall :size="20" />
Expand Down Expand Up @@ -999,7 +1006,7 @@
/**
* Update this.localContact and set this.fixed
*
* @param {Contact} contact the contact to clone

Check warning on line 1009 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The type 'Contact' is undefined
*/
async updateLocalContact(contact) {
// create empty contact and copy inner data
Expand Down Expand Up @@ -1050,7 +1057,7 @@
/**
* Should display the property
*
* @param {Property} property the property to check

Check warning on line 1060 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The type 'Property' is undefined
* @return {boolean}
*/
canDisplay(property) {
Expand Down Expand Up @@ -1203,4 +1210,8 @@
overflow: hidden;
text-overflow: ellipsis;
}

.quick-actions {
display: flex;
}
</style>
Loading