Skip to content

Conversation

@AntKru
Copy link
Contributor

@AntKru AntKru commented Jan 23, 2026

Closes #4314

Shows only one button with a popover if there are more than one email addresses or phone numbers.

image image image

@AntKru AntKru self-assigned this Jan 23, 2026
@AntKru AntKru added the 2. developing Work in progress label Jan 23, 2026
@SebastianKrupinski
Copy link
Contributor

Hi @AntKru

Looks great so far! Good work.

@AntKru AntKru requested a review from GretaD January 23, 2026 14:10
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/ContactDetails.vue 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AntKru AntKru marked this pull request as ready for review January 26, 2026 08:44
@AntKru AntKru added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 26, 2026
@AntKru AntKru force-pushed the enh/4314/multiple-email-phone-buttons branch from 00a812d to e306088 Compare January 27, 2026 11:04
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looking good, nice job!

@hamza221 hamza221 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 27, 2026
@hamza221
Copy link
Contributor

hamza221 commented Jan 27, 2026

Can you change it to fix so we can backport it ? and rebase on main
Great work btw 🚀

@hamza221
Copy link
Contributor

and please backport to stable8.3 and stable7.3

@AntKru AntKru force-pushed the enh/4314/multiple-email-phone-buttons branch from e306088 to 7f7aebc Compare January 28, 2026 09:05
@AntKru
Copy link
Contributor Author

AntKru commented Jan 28, 2026

/backport to stable8.3

@AntKru
Copy link
Contributor Author

AntKru commented Jan 28, 2026

/backport to stable7.3

@AntKru AntKru merged commit f187fab into main Jan 28, 2026
67 of 68 checks passed
@AntKru AntKru deleted the enh/4314/multiple-email-phone-buttons branch January 28, 2026 09:19
@GretaD GretaD changed the title feat: group multiple emails or phone numbers fix: group multiple emails or phone numbers Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Phone and email buttons

5 participants