Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

Summary

  • Added proper detection of address book ACLs
  • Adjusted Contact details edit and delete

Required for #nextcloud/server#55169

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.75%. Comparing base (a3cd2c5) to head (a4a0a2f).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ContactDetails.vue 0.00% 5 Missing ⚠️
src/store/addressbooks.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4728      +/-   ##
============================================
- Coverage     10.76%   10.75%   -0.02%     
  Complexity      291      291              
============================================
  Files           128      128              
  Lines          6512     6520       +8     
  Branches       1191     1195       +4     
============================================
  Hits            701      701              
- Misses         5690     5697       +7     
- Partials        121      122       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Two small nag comments:

  1. make this a fix commit. You are not adding a feature. you are fixing the handling of ACLs
  2. relabel the commit message accordingly. the fix is not specific to recently contacted but any addressbook with fine-granular ACLs

This should be backported, as a fix

Signed-off-by: SebastianKrupinski <[email protected]>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/issue-55169-delete-recent-contact branch from e250829 to a4a0a2f Compare September 24, 2025 10:56
@SebastianKrupinski SebastianKrupinski changed the title feat: delete recent contact fix: detect addressbook ACL's properly Sep 24, 2025
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable8.0

@SebastianKrupinski
Copy link
Contributor Author

Looks good!

Two small nag comments:

1. make this a `fix` commit. You are not adding a feature. you are fixing the handling of ACLs

2. relabel the commit message accordingly. the fix is not specific to recently contacted but any addressbook with fine-granular ACLs

This should be backported, as a fix

Done

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable7.3

@SebastianKrupinski SebastianKrupinski merged commit bf760fb into main Sep 24, 2025
42 of 44 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/issue-55169-delete-recent-contact branch September 24, 2025 10:59
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Development

Successfully merging this pull request may close these issues.

3 participants