-
Notifications
You must be signed in to change notification settings - Fork 199
fix: detect addressbook ACL's properly #4728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: detect addressbook ACL's properly #4728
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4728 +/- ##
============================================
- Coverage 10.76% 10.75% -0.02%
Complexity 291 291
============================================
Files 128 128
Lines 6512 6520 +8
Branches 1191 1195 +4
============================================
Hits 701 701
- Misses 5690 5697 +7
- Partials 121 122 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Two small nag comments:
- make this a
fixcommit. You are not adding a feature. you are fixing the handling of ACLs - relabel the commit message accordingly. the fix is not specific to recently contacted but any addressbook with fine-granular ACLs
This should be backported, as a fix
Signed-off-by: SebastianKrupinski <[email protected]>
e250829 to
a4a0a2f
Compare
|
/backport to stable8.0 |
Done |
|
/backport to stable7.3 |
Summary
Required for #nextcloud/server#55169