Skip to content

[stable5.5] fix(ui): escape organization/title properties #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamza221 merged 1 commit into from
Aug 18, 2025
Merged

[stable5.5] fix(ui): escape organization/title properties #4622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"debounce": "^1.2.1",
"downloadjs": "^1.4.7",
"ical.js": "^1.5.0",
"lodash": "^4.17.21",
"moment": "^2.29.4",
"p-limit": "^4.0.0",
"qr-image": "^3.2.0",
Expand Down
5 changes: 3 additions & 2 deletions src/components/ContactDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@
<template #icon>
<IconMail :size="20" />
</template>
<ActionLink v-for="emailAddress in emailAddressList"

Check warning on line 233 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / eslint 

Variable 'emailAddress' is already declared in the upper scope
:key="emailAddress"
:href="'mailto:' + emailAddress">
<template #icon>
Expand Down Expand Up @@ -369,6 +369,7 @@
</template>

<script>
import escape from 'lodash/fp/escape.js'
import { showError } from '@nextcloud/dialogs'

import { stringify } from 'ical.js'
Expand Down Expand Up @@ -717,9 +718,9 @@
organization,
})
} else if (title) {
return title
return escape(title)
} else if (organization) {
return organization
return escape(organization)
}

return ''
Expand Down Expand Up @@ -971,7 +972,7 @@
/**
* Update this.localContact and set this.fixed
*
* @param {Contact} contact the contact to clone

Check warning on line 975 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / eslint 

The type 'Contact' is undefined
*/
async updateLocalContact(contact) {
// create empty contact and copy inner data
Expand Down Expand Up @@ -1022,7 +1023,7 @@
/**
* Should display the property
*
* @param {Property} property the property to check

Check warning on line 1026 in src/components/ContactDetails.vue

View workflow job for this annotation

GitHub Actions / eslint 

The type 'Property' is undefined
* @return {boolean}
*/
canDisplay(property) {
Expand Down
Loading