Skip to content

feat(ShareByCircleProvider): Implement IShareProviderGetUsers #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Jan 15, 2026
Merged

feat(ShareByCircleProvider): Implement IShareProviderGetUsers #2290

provokateurin merged 1 commit into from
Jan 15, 2026
+14 −1

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Jan 15, 2026

No description provided.

@provokateurin provokateurin added this to the Nextcloud 33 milestone Jan 15, 2026
@provokateurin provokateurin self-assigned this Jan 15, 2026
@nickvergessen nickvergessen mentioned this pull request Jan 15, 2026
Closed
ArtificialOwl
ArtificialOwl reviewed Jan 15, 2026
View reviewed changes
@provokateurin provokateurin force-pushed the feat/ShareByCircleProvider/implement-IShareProviderGetUsers branch from 5388695 to 7be78cf Compare January 15, 2026 10:01
icewind1991
icewind1991 previously requested changes Jan 15, 2026
View reviewed changes
@provokateurin provokateurin force-pushed the feat/ShareByCircleProvider/implement-IShareProviderGetUsers branch from 7be78cf to 5388695 Compare January 15, 2026 11:10
@provokateurin
Copy link
Member Author

provokateurin commented Jan 15, 2026

Forced pushed back the earlier correct version.

@icewind1991
Copy link
Member

icewind1991 commented Jan 15, 2026

Forced pushed back the earlier correct version.

You can go back to 7be78cf as the issue I ran into is separate (#2291)

@provokateurin provokateurin force-pushed the feat/ShareByCircleProvider/implement-IShareProviderGetUsers branch from 5388695 to 7be78cf Compare January 15, 2026 14:18
@icewind1991
Copy link
Member

icewind1991 commented Jan 15, 2026

Double checking that the provided share is a circle share probably makes sense, though not strictly necessary.

@provokateurin provokateurin merged commit 070bc80 into master Jan 15, 2026
85 of 86 checks passed
@provokateurin provokateurin deleted the feat/ShareByCircleProvider/implement-IShareProviderGetUsers branch January 15, 2026 15:12
@icewind1991 icewind1991 mentioned this pull request Jan 15, 2026
Draft
5 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

Assignees

@provokateurin provokateurin

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin @icewind1991 @ArtificialOwl