Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Dec 23, 2025

Summary

  • Added functionality to restrict inviting only system users
  • Removed calls to the DAV backend the contacts controller already checks all available dav address books

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SebastianKrupinski SebastianKrupinski changed the title feat: restrict calendar invitation users feat: restrict calendar invitation participants Dec 23, 2025
@ChristophWurst ChristophWurst requested review from GretaD and removed request for ChristophWurst January 12, 2026 14:55
@GVodyanov
Copy link
Contributor

Is this something we want added to settings too?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of sync with the server changes -> won't work

nextcloud/server#57231

}

$result = $this->contactsManager->search($search, ['FN', 'EMAIL'], ['enumeration' => false]);
$externalAttendeesDisabled = $this->appConfig->getValueBool('dav', 'caldav.external_attendees_disabled', false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$externalAttendeesDisabled = $this->appConfig->getValueBool('dav', 'caldav.external_attendees_disabled', false);
$externalAttendeesDisabled = $this->appConfig->getValueBool('dav', 'caldav_external_attendees_disabled', false);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

@SebastianKrupinski
Copy link
Contributor Author

Is this something we want added to settings too?

This a admin setting, we could add this to dav setting for easy discovery, but design and @ChristophWurst would need to make that decision

@ChristophWurst
Copy link
Member

Documented configuration is sufficient as a first version

@SebastianKrupinski SebastianKrupinski force-pushed the feat/restrict-calendar-invitation-users branch from a140dd8 to 59278b3 Compare January 15, 2026 15:56
@SebastianKrupinski SebastianKrupinski force-pushed the feat/restrict-calendar-invitation-users branch 2 times, most recently from 7d56a75 to 59d7163 Compare January 15, 2026 16:45
@SebastianKrupinski SebastianKrupinski force-pushed the feat/restrict-calendar-invitation-users branch from 59d7163 to 0505cef Compare January 15, 2026 20:50
@SebastianKrupinski SebastianKrupinski merged commit 2c37b80 into main Jan 15, 2026
43 of 45 checks passed
@SebastianKrupinski SebastianKrupinski deleted the feat/restrict-calendar-invitation-users branch January 15, 2026 20:56
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jan 15, 2026
@SebastianKrupinski
Copy link
Contributor Author

Documented configuration is sufficient as a first version

Documentation
nextcloud/documentation#13988

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable6.1

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

4 participants