feat: Meeting Proposals

[SebastianKrupinski]

Summary

Resolves: nextcloud/server#50084

Proposal Editor

Proposal Overview

Proposal Participant Availability

Proposal Status and List

[codecov]

Codecov Report

❌ Patch coverage is 0% with 771 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.67%. Comparing base (11fc845) to head (4a948f0).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/views/Proposal/ProposalEditor.vue	0.00%	424 Missing ⚠️
src/components/Proposal/ProposalResponseMatrix.vue	0.00%	114 Missing ⚠️
src/views/Proposal/ProposalPublic.vue	0.00%	84 Missing ⚠️
...components/AppNavigation/Proposal/ProposalList.vue	0.00%	79 Missing ⚠️
...rc/components/Proposal/ProposalParticipantItem.vue	0.00%	37 Missing ⚠️
src/components/Proposal/ProposalDateItem.vue	0.00%	31 Missing ⚠️
src/views/Calendar.vue	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7072      +/-   ##
==========================================
- Coverage   14.84%   13.67%   -1.18%     
==========================================
  Files         212      218       +6     
  Lines       10297    11180     +883     
  Branches     2474     2704     +230     
==========================================
  Hits         1529     1529              
- Misses       8418     9301     +883     
  Partials      350      350              

Flag	Coverage Δ
javascript	13.67% <0.00%> (-1.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SebastianKrupinski]

Only 3.2K of lines... I can do better 😆

[ChristophWurst]

Extract the typescript introduction into a separate PR

[SebastianKrupinski]

Basic functionality is implemented.

• Proposal Creation
• Proposal Modification
• Proposal Deletion
• Proposal Management (List of proposals)
• Proposal Response (Participant date selection)
• Mail notifications on Create / Modify / Delete
• iMip Messaging to internal users on Create / Modify / Delete (Time blockers in calendar)

[SebastianKrupinski]

Remain Tasks,

• Discuss TODO's with @ChristophWurst
• Investigate why UI only shows one instance
• Implement Group expansion
• Implement Tests
• Functional Review with @ericfischereu and @nimishavijay
• Design Review with @ericfischereu and @nimishavijay

[ChristophWurst]

• Mail notifications on Create / Modify / Delete

• iMip Messaging to internal users on Create / Modify / Delete (Time blockers in calendar)

These two sound optional. Does it bring your PR closer to a reviewable size when you split them off?

[SebastianKrupinski]

• Mail notifications on Create / Modify / Delete
• iMip Messaging to internal users on Create / Modify / Delete (Time blockers in calendar)

These two sound optional. Does it bring your PR closer to a reviewable size when you split them off?

Those two where part of the original spec, also they are part of the feature that we are trying to replicate, and kind of necessary. The one thing we could drop is the iMip messaging but that is only 100 lines so not a huge amount of code.

[SebastianKrupinski]

Completed initial review with @nimishavijay @jancborchardt @hamza221 today

[nimishavijay]

Notes from the design review:

Overall

• When you fill in users list them vertically using listitems instead of userbubbles
• Fullcalendar buttons should be adjusted to match NC design
• remove zoom buttons? unintuitive. instead make default snapto to 15 mins and bring up default editor to adjust
• Instead of showing a blank block for past dates, show just the heading
• Instead of showing available blocks, show busy blocks with the same striked out pattern as in new free/busy
• Show a close button on a selected time in the fullcalendar
• When you click on a date,
• Don't show delete button if it can't be deleted
• Don't show close or cancel button
• Track who voted
• Follow up for next versions: Once you fill out organizers and duration, automatically suggest a few timeslots based on free/busy

Navigation

• Show list of proposals in the left navigation below appointment schedules in a new section
• Similar to apppointment schedules show a plus button next to the navigation caption which opens the create new proposals
• Each item can have an icon or 2 to indicate responses

Papercuts

• "Create Meeting Proposal" --> "Create meeting proposal" use sentence case, not title case
• Also similar for buttons in the bottom row
• "today" "week" "day" --> "Today" "Week" "Day" in fullcalendar component
• Move all the buttons to the right, and follow the order of having the primary button at the end, and then the rest of the buttons

Voting screen

• Always show organizer with avatar and name
• Show other participants if possible?
• Make the dates nicer, use the full words
  • If it is the current year, don't show the year
• Possibly copy exactly the appointment voting screen
  • Show a list of dates in the middle column, possibly arranged in a a clearer way (eg divide into sections based on month)
  • On the left column show all the info about the proposal
  • Add a timezone picker!
  • Possibly show who already responded to a date like in MS

Email

• Title, description, location, duration, organizer for first version
• Participants and proposed times as a follow up?

To do for Nim:

• Design of time slots inside the proposal creation/update view
• Design of showing who responded to what inside the proposal view
• Layout improvements to the voting page

[ChristophWurst]

Those two where part of the original spec, also they are part of the feature that we are trying to replicate, and kind of necessary. The one thing we could drop is the iMip messaging but that is only 100 lines so not a huge amount of code.

Okay. Thank you for the insights.

[st3iny]

Tested this and found some issues:

1. Attendee emails: Date is always Thursday, January 1, 1970
2. Avatars are not working in the modal and on the public page (probably due to display name being used instead of user id).
3. Creating an event is not working properly (after attendees reacted).

Blockers have been addressed.

[SebastianKrupinski]

@nimishavijay @st3iny thank you, I will make the changes later today

[SebastianKrupinski]

Tested this and found some issues:

1. Attendee emails: Date is always `Thursday, January 1, 1970`

2. Avatars are not working in the modal and on the public page (probably due to display name being used instead of user id).

3. Creating an event is not working properly (after attendees reacted).

Fixed.

1. Attendee email dates now show properly with time span and no longer are bulleted
2. Avatars now show properly
3. Converting a meeting to a proposal now works properly, although the is a issue, that will need to be addresses in a followup
4. Fixed timezone selector on public view , it now changes the times properly
5. Fixed selected time slot drag and drop

[st3iny]

Creating the event is still not working.

I can see network requests and the proposal being deleted. However, there is no calendar event being created in the organizer's calendar.

The rest seems to be fixed now.

[SebastianKrupinski]

Creating the event is still not working.

I can see network requests and the proposal being deleted. However, there is no calendar event being created in the organizer's calendar.

The rest seems to be fixed now.

Yeah that was the glitch I mentioned in the last comment. It resolved.

[st3iny]

Let's drop support for Nextcloud < 32 and merge this to circumvent the iMip API incompatibilties on Nextcloud < 32 (and < 31 respectively).

Design feedback has been addressed.

[SebastianKrupinski]

Temporarily removed the time blocking part of this feature (iMip Sending) due to missing changes in server.

Will be added in:

#7315