feat: Add system tags to AI generated files #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
julien-nc
requested changes
Nov 26, 2025
Signed-off-by: Marcel Klehr <[email protected]>
kyteinsky
reviewed
Nov 28, 2025
Comment on lines
+27
to
+41
| public function getAiTag() { | ||
| try { | ||
| return $this->systemTagManager->getTag(self::AI_TAG_NAME, true, true); | ||
| } catch (TagNotFoundException $e) { | ||
| return $this->systemTagManager->createTag(self::AI_TAG_NAME, true, true); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * @param string $fileId | ||
| * @return void | ||
| * @throws TagNotFoundException | ||
| */ | ||
| public function assignAiTagToFile(string $fileId) { | ||
| $this->systemTagObjectMapper->assignTags($fileId, 'files', $this->getAiTag()->getId()); |
Contributor
There was a problem hiding this comment.
perhaps the tag can be created in a migration so we're sure it exists and then store the tag's ID in a config. It might be a little better to not create ISystemTag every time or is it not that impactful?
Contributor
There was a problem hiding this comment.
perhaps the tag can be created in a migration so we're sure it exists
can they be deleted by users? If yes, then ignore this review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.