Change how small number inputs are rendered #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edward-ly
reviewed
May 7, 2025
Contributor
edward-ly
left a comment
edward-ly
left a comment
There was a problem hiding this comment.
Some possible design improvements:
- Add an "active" attribute highlighting the button that was last clicked (or the default value when the form is opened).
- Add a "Custom" button which toggles the visibility of the input field (which would be hidden by default to avoid mixing input types). Clicking on one of the 1-5 buttons would also hide the input field.
…lt value Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
… reactive Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/noid/small-number-field
branch
from
43e7a08 to
e49ba51
Compare
Member
Author
|
@edward-ly Thanks for the feedback and suggestions. Both are implemented. It was a bit tricky to make the state reactive to outside changes, especially when typing into the "custom" input field. If you wanna type "11", you start by typing "1" and the value changes immediately and 1 is considered as not custom so the 1 button is highlighted and the input field disappears. Simple solution is to debounce the number input update event. Kooha-2025-05-15-11-42-04.webm |
janepie
approved these changes
May 15, 2025
Member
janepie
left a comment
janepie
left a comment
There was a problem hiding this comment.
Looks good! Cannot test with >4 pictures right now, because OpenAI has a max of 4 I think. Maybe something we could chunk in the future?
Member
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the field's default value is under 10, we render it like that:
refs #215