fix(ChattyLLM): Fix disappearing messages #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
fix/disappearing-chat-messages
branch
from
d415bc1 to
d3eb838
Compare
kyteinsky
approved these changes
May 6, 2025
| $message->setRole($role); | ||
| $message->setContent($content); | ||
| $message->setTimestamp($timestamp); | ||
| $message->setSources('[]'); |
Contributor
There was a problem hiding this comment.
it should be automatically be populated by the default value, no?
Member
Author
There was a problem hiding this comment.
Feel free to test. I'm not sure why that doesn't work.
Member
Author
There was a problem hiding this comment.
the message gets returned without refetching it from the db. In the db the default is applied, but not in the message object
Contributor
There was a problem hiding this comment.
ah alright that makes sense. Nice one.
julien-nc
approved these changes
May 6, 2025
janepie
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.