Updated avatar handling #7098
Updated avatar handling #7098
Conversation
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Just a minor issue with the license header in the xml file
| ~ | ||
| ~ You should have received a copy of the GNU Affero General Public License | ||
| ~ along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| --> |
There was a problem hiding this comment.
we usually don't prefix license header comment lines with ~
tobiasKaminsky
force-pushed
the
avatars
branch
from
d195b8f to
630bea3
Compare
|
Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java -2
See the complete overview on Codacy |
tobiasKaminsky
force-pushed
the
avatars
branch
from
630bea3 to
e844abf
Compare
Signed-off-by: tobiasKaminsky <[email protected]>
AndyScherzinger
force-pushed
the
avatars
branch
from
e844abf to
85551b5
Compare
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
AndyScherzinger
force-pushed
the
avatars
branch
from
85d8950 to
840d7e5
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7098.apk |
CodacyLint
SpotBugs (new)
SpotBugs (master)
|
|
master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-master-light-blue |
|
stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-stable-light-blue |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-IT-stable |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-IT-master |
|
master-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-master-dark-blue |
|
stable-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16781-Screenshot-stable-dark-blue |
Updated avatar handling Signed-off-by: thelittlefireman <[email protected]>
For: nextcloud/server#23467
Signed-off-by: tobiasKaminsky [email protected]
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests