Skip to content

Add support for metadata: size (width/height) and geolocation #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 1 commit into from
Aug 28, 2023
Merged

Add support for metadata: size (width/height) and geolocation #1178

tobiasKaminsky merged 1 commit into from
Aug 28, 2023

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Aug 11, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

AndyScherzinger
AndyScherzinger previously approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndyScherzinger AndyScherzinger added this to the NC Android Lib 2.16.0 milestone Aug 15, 2023
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Aug 28, 2023

master-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/2074-IT-master-08-27

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Aug 28, 2023

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/2074-IT-stable-08-27

@tobiasKaminsky tobiasKaminsky merged commit d6d062d into master Aug 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the gps branch August 28, 2023 10:09
@joshtrichards joshtrichards mentioned this pull request Nov 18, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

NC Android Lib 2.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger