refactor(app): modernize and tidy up public entrypoint by joshtrichards · Pull Request #7463 · nextcloud/all-in-one

joshtrichards · 2026-01-20T19:01:48Z

Code was already pretty tidy; this just elevates it a bit more while cleaning up some minor tidbits.

Refactored php/public/index.php for improved readability, maintainability, and adherence to best practices
Introduced config constants; added type hints to all route closures
Grouped variables by domain/context for template clarity
Used route grouping with $group in Slim
Switched to consistent namespace usage
Added/updated comments
Ensured root route type hints ServerRequestInterface rather than RequestInterface
Dropped unused (and erroneous AFAIK) profile alias for the /containers/ route

Not offended if you don't merge this, but I was reading through it anyhow. ;-)

Shouldn't be any breaking changes; largely cosmetic. If something is broken it's probably a typo on my part. ;-)

php/public/index.php

szaimen · 2026-01-28T14:11:38Z

There are unfortunately some conflicts now, so this needs a rebase

pabzm · 2026-01-29T14:13:06Z

I like some of these changes, e.g. adding type hints. But having all changes in one commit makes it really hard to review, especially if actual changes are mixed with reordering lines.

For a proper review I would need this cleaned up into smaller commits, or at least stripped by the reordering.

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

Signed-off-by: Josh <josh.t.richards@gmail.com>

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

joshtrichards · 2026-02-16T15:02:58Z

@pabzm:

I like some of these changes, e.g. adding type hints. But having all changes in one commit makes it really hard to review, especially if actual changes are mixed with reordering lines.

For a proper review I would need this cleaned up into smaller commits, or at least stripped by the reordering.

Fixed.

szaimen · 2026-02-17T12:28:34Z

php/public/index.php

+//-------------------------------------------------
+
+// TODO: Figure out why the default plain text renderer is being used by logging
+// TODO: Change logging to not generate stack traces for 404s


@pabzm didnt you find a solution to this already? :)

Indeed, and I had meant to post it, which I forgot. Thank you for the reminder!

See #7631

Thank you! I guess this todo can after the merge of #7631 then be removed, right? :)

@joshtrichards please remove this todo here after #7631 is merged. Thanks! :)

szaimen · 2026-02-20T12:21:47Z

php/public/index.php

+//-------------------------------------------------
+
+// TODO: Figure out why the default plain text renderer is being used by logging
+// TODO: Change logging to not generate stack traces for 404s


@joshtrichards please remove this todo here after #7631 is merged. Thanks! :)

pabzm · 2026-02-25T09:02:32Z

php/public/index.php

 });

-// Auth Redirector
-$app->get('/', function (\Psr\Http\Message\RequestInterface $request, Response $response, array $args) use ($container) {


\Psr\Http\Message\RequestInterface is not the same as Request, which is taken from Psr\Http\Message\ServerRequestInterface, please don't change that.

pabzm

Thank you for this effort! I would be willing to merge it if you address the small issues.

pabzm · 2026-02-25T09:10:45Z

php/public/index.php

+ini_set('max_execution_time',      AIO_MAX_EXECUTION_TIME); // Prevent timeouts on slow networks
+ini_set('session.cookie_lifetime', AIO_COOKIE_LIFETIME); // Auto-logout on browser close
+ini_set('session.gc_maxlifetime',  AIO_SESSION_MAX_LIFETIME); // 24h session duration
+ini_set('log_errors_max_len',      AIO_LOG_ERRORS_MAX_LEN); // Full error logs


With the abstractions of the values in constants we cannot refer to the default values in comments here. If they ever get changed, the comments would get confusing.

pabzm · 2026-02-25T09:12:03Z

php/public/index.php

+        'is_dri_device_enabled' => $configurationManager->nextcloudEnableDriDevice,
+        'is_nvidia_gpu_enabled' => $configurationManager->enableNvidiaGpu,
+        'is_talk_recording_enabled' => $configurationManager->isTalkRecordingEnabled,
+	'is_docker_socket_proxy_enabled' => $configurationManager->isDockerSocketProxyEnabled,


Please fix the indentation here (should be spaces, not a tab)

pabzm · 2026-02-25T09:16:22Z

php/public/index.php

        'was_start_button_clicked' => $configurationManager->wasStartButtonClicked,
        'has_update_available' => $dockerActionManager->isAnyUpdateAvailable(),
-        'is_mastercontainer_update_available' => ( $bypass_mastercontainer_update ? false : $dockerActionManager->IsMastercontainerUpdateAvailable() ),
+        'is_mastercontainer_update_available' => ( $bypassMastercontainerUpdate ? false : $dockerActionManager->IsMastercontainerUpdateAvailable() ),


This whole commit is a fixup for f88957a#r2851763584, isn't it?

For next time I'd like to ask you to squash such commits before requesting a review. Or even better: split off the variable renaming into a separate commit, so it stays atomic. Thanks!

szaimen mentioned this pull request Jan 21, 2026

publish new images after recent PRs are merged and tested #7428

Closed

37 tasks

szaimen added this to the next milestone Jan 21, 2026

szaimen added 2. developing Work in progress enhancement New feature or request technical debt labels Jan 21, 2026

joshtrichards force-pushed the jtr/refactor-app-public branch from 895a860 to 4a2d5bb Compare January 23, 2026 15:54

joshtrichards marked this pull request as ready for review January 23, 2026 22:25

joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 23, 2026

asavageiv reviewed Jan 24, 2026

View reviewed changes

php/public/index.php Show resolved Hide resolved

szaimen requested a review from pabzm January 26, 2026 09:27

szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 28, 2026

szaimen mentioned this pull request Jan 30, 2026

publish new images after recent PRs are merged and tested #7521

Closed

23 tasks

szaimen modified the milestones: v12.6.0, next Jan 30, 2026

szaimen mentioned this pull request Feb 2, 2026

publish new images after recent PRs are merged and tested #7535

Closed

28 tasks

szaimen modified the milestones: v12.6.1, next Feb 2, 2026

szaimen mentioned this pull request Feb 13, 2026

publish new images after recent PRs are merged and tested #7588

Closed

31 tasks

szaimen modified the milestones: v12.7.0, next Feb 13, 2026

szaimen marked this pull request as draft February 13, 2026 13:40

joshtrichards force-pushed the jtr/refactor-app-public branch from 4a2d5bb to 2d75a54 Compare February 16, 2026 14:16

joshtrichards added 4 commits February 16, 2026 10:00

refactor(app): add route type hints

b8b078a

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

refactor(app): add bootstrap config constants

57af56c

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

refactor(app): group API routes

b3e6ae7

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

refactor(app): clarify containers view params

f88957a

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

joshtrichards added 4 commits February 16, 2026 10:00

refactor(app): drop unused containers route name

8def11e

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

refactor(app): misc code formatting cleanup

9d49ba5

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

chore: camelCase / adjust variable names

79fb380

Signed-off-by: Josh <josh.t.richards@gmail.com>

docs(apps): tidy up comments on constants/php settings

2cc9f67

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

joshtrichards force-pushed the jtr/refactor-app-public branch from a825df9 to 2cc9f67 Compare February 16, 2026 15:01

joshtrichards marked this pull request as ready for review February 16, 2026 15:03

joshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 16, 2026

szaimen reviewed Feb 17, 2026

View reviewed changes

szaimen requested changes Feb 20, 2026

View reviewed changes

pabzm reviewed Feb 25, 2026

View reviewed changes

pabzm requested changes Feb 25, 2026

View reviewed changes

szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 25, 2026

szaimen modified the milestones: v12.8.0, next Feb 26, 2026

szaimen mentioned this pull request Feb 26, 2026

publish new images after recent PRs are merged and tested #7665

Open

36 tasks

Conversation

joshtrichards commented Jan 20, 2026

Uh oh!

Uh oh!

szaimen commented Jan 28, 2026

Uh oh!

pabzm commented Jan 29, 2026

Uh oh!

joshtrichards commented Feb 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pabzm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants