Skip to content

[stable32] fix: activity insert #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miaulalala merged 1 commit into from
Nov 11, 2025
Merged

[stable32] fix: activity insert #2219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions lib/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
use OCP\IConfig;
use OCP\IDBConnection;
use Psr\Log\LoggerInterface;
use Throwable;

/**
* @brief Class for managing the data in the activities
Expand Down Expand Up @@ -108,8 +107,10 @@ public function bulkSend(IEvent $event, array $affectedUsers): array {

$activityIds = [];
try {
$qb = $this->connection->getQueryBuilder();
$qb->insert('activity')
if ($this->insertActivity === null) {
$this->insertActivity = $this->connection->getQueryBuilder();
}
$this->insertActivity->insert('activity')
->values([
'app' => $this->insertActivity->createParameter('app'),
'subject' => $this->insertActivity->createParameter('subject'),
Expand All @@ -127,7 +128,7 @@ public function bulkSend(IEvent $event, array $affectedUsers): array {
'object_id' => $this->insertActivity->createParameter('object_id'),
]);

$qb->setParameters([
$this->insertActivity->setParameters([
'app' => $event->getApp(),
'type' => $event->getType(),
'user' => $event->getAuthor(),
Expand All @@ -144,14 +145,15 @@ public function bulkSend(IEvent $event, array $affectedUsers): array {
]);

foreach ($affectedUsers as $affectedUser) {
$qb->setParameter('affecteduser', $affectedUser);
$qb->executeStatement();
$activityIds[$qb->getLastInsertId()] = (string)$affectedUser;
$this->insertActivity->setParameter('affecteduser', $affectedUser);
$this->insertActivity->executeStatement();
$activityIds[$this->insertActivity->getLastInsertId()] = (string)$affectedUser;
}

$this->connection->commit();
} catch (Throwable) {
} catch (Exception $e) {
// Make sure to always roll back, otherwise the outer code runs in a failed transaction
$this->logger->error('Could not create bulk activities', ['exception' => $e]);
$this->connection->rollBack();
return [];
}
Expand Down
Loading