Skip to content

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented May 26, 2025

As a preparation for the Vue 3 migration:

  • Update ESLint dependency (v8 is EOL!)
  • Update to matching Nextcloud config
  • Adjust code to match new (stricter) rules

Inspired from nextcloud/firstrunwizard#1603

@artonge artonge self-assigned this May 26, 2025
@artonge artonge added this to the Nextcloud 32 milestone May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 27.87879% with 119 lines in your changes missing coverage. Please review.

Project coverage is 31.14%. Comparing base (26bbbd2) to head (e632b8b).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/richObjects.ts 31.25% 44 Missing ⚠️
src/store/settings-store.js 0.00% 22 Missing ⚠️
src/views/ActivityAppFeed.vue 0.00% 11 Missing ⚠️
src/components/CheckboxInput.vue 0.00% 6 Missing ⚠️
src/settings-personal.js 0.00% 5 Missing ⚠️
src/app.ts 0.00% 4 Missing ⚠️
src/components/ActivityGrid.vue 0.00% 4 Missing ⚠️
src/components/ActivityGroup.vue 0.00% 3 Missing ⚠️
src/settings-admin.js 0.00% 3 Missing ⚠️
src/views/UserSettings.vue 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
+ Coverage   30.80%   31.14%   +0.34%     
==========================================
  Files          43       43              
  Lines        1620     1583      -37     
  Branches      110      110              
==========================================
- Hits          499      493       -6     
+ Misses       1095     1064      -31     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented May 26, 2025

Activity    Run #2600

Run Properties:  status check passed Passed #2600  •  git commit b6c9550457: chore: update to ESLint v9 and adjust code
Project Activity
Branch Review artonge/chore/vue3
Run status status check passed Passed #2600
Run duration 02m 14s
Commit git commit b6c9550457: chore: update to ESLint v9 and adjust code
Committer Louis
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@artonge
Copy link
Collaborator Author

artonge commented May 26, 2025

/compile amend /

@artonge artonge requested a review from susnux May 26, 2025 09:58
@artonge artonge marked this pull request as ready for review May 26, 2025 09:58
@artonge artonge mentioned this pull request May 26, 2025
2 tasks
@artonge artonge force-pushed the artonge/chore/vue3 branch from bd08c12 to 5f81ebe Compare May 26, 2025 11:46
@artonge
Copy link
Collaborator Author

artonge commented May 26, 2025

/compile amend /

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@susnux susnux merged commit c3e10aa into master May 26, 2025
52 of 53 checks passed
@susnux susnux deleted the artonge/chore/vue3 branch May 26, 2025 13:48
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants